search

jayk / minimap-autohide

Atom package to automatically hide the mini-map when you aren't using it.
MIT License
8 stars 6 forks source link

Deprecated selector in `minimap-autohide/styles/minimap-autohide.less` #17

Open nibushibu opened 7 years ago

nibushibu commented 7 years ago

In minimap-autohide/styles/minimap-autohide.less:

Starting from Atom v1.13.0, the contents of atom-text-editor elements are no longer encapsulated within a shadow DOM boundary. This means you should stop using :host and ::shadow pseudo-selectors, and prepend all your syntax selectors with syntax--. To prevent breakage with existing style sheets, Atom will automatically upgrade the following selectors:

Automatic translation of selectors will be removed in a few release cycles to minimize startup time. Please, make sure to upgrade the above selectors as soon as possible.

delblues commented 7 years ago

the same here, but now, the minimap has gone after I selected off autohide.

ansballard commented 7 years ago

This repo looks pretty dead, I may fork tonight and see if I can fix the current deprecations. If I do I'll post back here with a different npm module people can switch to if they want.

Update: I've forked and published a version rewritten in vanilla js and with both current deprecation warnings fixed at apm install minimap-autohider or https://atom.io/packages/minimap-autohider. I'll do my best to fix a few of the issues left on this repo when I get a chance.

skull-squadron commented 7 years ago

@ansballard No deprecation cops on 1.14.1. 🍺

DimovAngel commented 7 years ago

Starting from Atom v1.13.0, the contents of atom-text-editor elements are no longer encapsulated within a shadow DOM boundary. This means you should stop using :host and ::shadow pseudo-selectors, and prepend all your syntax selectors with syntax--. To prevent breakage with existing style sheets, Atom will automatically upgrade the following selectors:

atom-text-editor::shadow atom-text-editor-minimap.scrolling, atom-text-editor::shadow atom-text-editor-minimap:hover => atom-text-editor.editor atom-text-editor-minimap.scrolling, atom-text-editor.editor atom-text-editor-minimap:hover atom-text-editor::shadow atom-text-editor-minimap => atom-text-editor.editor atom-text-editor-minimap Automatic translation of selectors will be removed in a few release cycles to minimize startup time. Please, make sure to upgrade the above selectors as soon as possible.

ansballard commented 7 years ago

@DimovAngel This repo has been deprecated, if you're having issues you'll want to uninstall it and install minimap-autohider instead (note the r at the end). If the issues persists, feel free to open a new issue at https://github.com/ansballard/minimap-autohider!