search

jayk1961 / arora

Automatically exported from code.google.com/p/arora
0 stars 0 forks source link

Arora should be able to use the system-wide settings #483

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
Arora (git "head") desn't pick the system-wide settings for proxy as described 
here:

http://code.google.com/p/arora/wiki/KDE4Integration

Attached patch proposes a fix, but some issues arise:

- Qt/X11 doesn't fetch the KDE4 proxy configuration yet
- There could be a performance overhead, it seems to be zero on Qt/X11, but I 
don't have another 
system to test (that can be improved by "caching" the system proxy information 
for HTTP, maybe, 
not sure that's a great idea)
- This potentially breaks the proxy configuration
- For Qt < 4.5, "Use the system settings" will have the same effect as a direct 
connection

Regarding the breaking the proxy configuration stuff, we currently store the 
proxy configuration 
as the index of the combo box that offers the list of possible proxy settings. 
That's problematic 
because changes like the changes introduced in this patch break the ordering of 
these options 
and so anyone who configured proxy settings might have to reconfigure those 
settings after 
applying this patch. I can post another patch that can work around this, but 
this will not scale well 
on the long term. Please let me know if there's a better solution, and I'll 
adapt the patch.

Moreover, we can't hide "Use the system settings" for Qt < 4.5, because that 
would mean the 
proxy configuration would be incompatible between Qt <= 4.4 and Qt >= 4.5.

I can also create another patch if you guys think the configuration is not 
intuitive enough or 
something like that.

Also, especially since this is my first contribution (attempt) for this 
project, feel free to bash my 
coding style. I've tried to stick to the recommendations in the wiki, not sure 
some of those have 
not slipped. I can provide a corrected patch if necessary as well.

Original issue reported on code.google.com by fernando...@gmail.com on 11 Jun 2009 at 9:25

Attachments:

GoogleCodeExporter commented 9 years ago 
I think the attached patch takes a better approach. It's a new design which no 
longer breaks the proxy 
configuration and is also more Qt < 4.5 friendly. The only remaining issues 
are, as I see it:

- Qt/X11 doesn't fetch the KDE4 proxy configuration yet
- There could be a performance overhead, it seems to be zero on Qt/X11, but I 
don't have another system to test 
(that can be improved by "caching" the system proxy information for HTTP, 
maybe, not sure that's a great idea)

I think is also more familar to Firefox users.

Original comment by fernando...@gmail.com on 11 Jun 2009 at 11:06

Attachments: