search

jaylenw / nota

Backend for AngularJSTodoApp, IonicTodoApp, & ElectronTodoApp. Create and Archive Notes in this back-end application providing RESTful APIs designed to be use with a front-end application. Archived on 2023/11/26.
https://nota.jaylenwimbish.com/
MIT License
1 stars 1 forks source link

Move the eslint tests into the build-n-deploy workflow #345

Closed jaylenw closed 11 months ago

jaylenw commented 2 years ago

Problem or Question?

We have an extra GitHub Action workflow that is not needed. We can delete the eslint workflow and run the eslint test in the build-n-deploy workflow. This will be more efficient.

Any additional Context?

When we were using Travis, the eslint workflow was created once GitHub Actions was available. Now since we have migrated everything away from Travis to GitHub Actions we can move the eslint tests into the build-n-deploy workflow.

Any issue(s) or pull request(s) that may be related to this?

N/A

jaylenw commented 2 years ago

docker-compose run --no-deps nota npm run linter will do the trick. I have verified that the exit code of the npm command will be observed by the ci runner. The --no-deps flag is used as we do not need the mongodb container to be started for running the lint tests.

jaylenw commented 11 months ago

Closing as this repository will be archived.