Welcome to opening a pull request. Thank you for contributing!
Review the checklist and do the right thing. If you have questions ask the
code owners
About PR reviews
PRs are viewed as follows:
Open PRs are considered ready for full review and merge.
We highly recommend starting with a draft so we can collaborate and have discussions as work
is being done. It's not required but certainly recommended.
Make small PRS, not large ones. If your PR is getting long, try to break it apart into two.
If you absolutely have to make a big one, make your commits clean.
Don't hesitate to set up a meeting with the code owners if it feels like we're stuck going back
and forth for too long.
[ ] PR Name: Please name this PR in format of
[TICKET_ID]: [BRIEF DESCRIPTION]. For example: MONO-0000: Implement
component X to use with Y
[ ] Ticket(s) and Related PR(s): Add the tickets that this PR will resolve
once merge. You can also add a list of related PR(s); this is useful when
to communicate that another PR must be reviewed first.
[ ] Change Description: Please update the above change list to provide a
list of changes done. This will be added to the commit when merged for a
useful commit description.
This can be omitted in the rare case that the PR is very small and the title
alone clearly explains what it does.
[ ] Tests: All code should have strong tests. If you have questions about
this please ask one of the code owners. All tests need to pass CI for all
test matrix combinations for your PR to be considered for merge.
[ ] Code Owner Review: Please add at least one repository code owner as a
reviewer. You are welcome to add anyone else you'd like feedback from.
[ ] Squash Commit with Details: It's hard to keep a perfect commit record
so we prefer squash commits. When doing squash commits the commit name
should auto fill the the PR name (formatted as defined in the PR Name
section above) plus (#123) where the number is the PR number. Set the
commit paragraph text to be the changes list above (don't include
"Changes" header, just the list).
======= READ AND DELETE =====
Welcome to opening a pull request. Thank you for contributing! Review the checklist and do the right thing. If you have questions ask the code owners
About PR reviews
PRs are viewed as follows:
Make small PRS, not large ones. If your PR is getting long, try to break it apart into two.
If you absolutely have to make a big one, make your commits clean.
Don't hesitate to set up a meeting with the code owners if it feels like we're stuck going back and forth for too long.
==== DELETE THE ABOVE ====
Ticket(s)
Related PR(s)
Changes
src/foo.tssrc/bar.tsChecklist
[TICKET_ID]: [BRIEF DESCRIPTION]. For example: MONO-0000: Implement component X to use with Y(#123)where the number is the PR number. Set the commit paragraph text to be the changes list above (don't include "Changes" header, just the list).