Closed jaylong255 closed 1 year ago
@diego3158 this is the repo i was talking about. this is my company site. this pull request is me updating the twitter logo to x. ideally i would have liked to use an svg like the other logos but it kept doing weird stuff and i don't have time to keep messing with it so i just used a png.
merging this pull request will use ci/cd to deploy automatically to production. opening and updating the pr deploys to the dev site at https://dev.cyberworldbuilders.com/. it uses GitHub Actions. if you look in the terraform
folder, you can actually see the IaC that expresses the AWS infrastructure that powers it.
For some reason I'm strugging to get the x svg to act right. Although I would prefer to have all of the social links using a uniform architecture, especially if that can be a simple svg... the x logo doesn't want to act right. I'm sure a legit frontend dev can make short work of this. That being said, I'm going to make an exception for x and use a small png image for now. I'm creating an issue to convert the image to an svg and post it in the community for some hungry frontend dev to maybe school me on how it's done. Thanks in advance, boss!
Ticket(s)
Related PR(s)
Changes
Checklist
[TICKET_ID]: [BRIEF DESCRIPTION]
. For example: MONO-0000: Implement component X to use with Y(#123)
where the number is the PR number. Set the commit paragraph text to be the changes list above (don't include "Changes" header, just the list).