I went off the rails making improvements that are out of scope with the initial task on pr 46. This has lead to it hanging around like a pet and we need to get it closed out soon. I left comments in the discussion that explain this in more detail.
https://github.com/jaylong255/cyberworld-site/pull/50#issuecomment-1874336648
"lets reign in the scope here. this is starting to look a bit ambitious for one single pr. all i really wanted here was to demonstrate that ci would run on merge with a respective cloud provider upon changes to its terraform code. it was more about authentication with terraform cloud/gcp than it was about managing actual resources on either provider. as long as that is done we can merge this and then move the rest of the changes to new issues/prs"
Description
I went off the rails making improvements that are out of scope with the initial task on pr 46. This has lead to it hanging around like a pet and we need to get it closed out soon. I left comments in the discussion that explain this in more detail.
Related PRs
46 - DevOps: Set Up CI/CD for GCP with TF Cloud and GH Actions
Related Issues
DevOps: Set Up CI/CD for GCP with TF Cloud and GH Actions #46
Related Discussion
https://github.com/jaylong255/cyberworld-site/pull/50#issuecomment-1874336648 "lets reign in the scope here. this is starting to look a bit ambitious for one single pr. all i really wanted here was to demonstrate that ci would run on merge with a respective cloud provider upon changes to its terraform code. it was more about authentication with terraform cloud/gcp than it was about managing actual resources on either provider. as long as that is done we can merge this and then move the rest of the changes to new issues/prs"