Closed egvimo closed 2 years ago
related #94
If you accept this PR, I can update the readme file, too.
I also can change the paths and names if you think others are better suited. They were just my preference.
@egvimo thank you for your contribution.
This is an effective implementation of https://github.com/jaymoulin/docker-jdownloader/issues/94#issuecomment-878397718 (which is still waiting for vote BTW) but I think it could have been easier.
Yes please change the README.md as everything must be related in the same commit. IMHO implementing only the exec
subfolder + cp in config.sh would ease review, bug avoiding, documentation maintaining and understanding for migrating users. (even if I checked, I could have missed some behaviours).
@jaymoulin You're right. I've reverted all my preferences and optimizations. Now only the new exec
folder is included. Everything else can be done separately.
After some thoughts I think app
would be a better choice for the folder. What do you think?
I've changed the folder to app
and updated everything accordingly. And I updated the K8s example with everything necessary to run the app.
This PR moves the main app to a separate folder (
app
). This way this directory can be mounted as a volume which persists the data after an update.THIS IS A BREAKING CHANGE! Because of the extra directory layer the mounts has to be changed.
I've created an image and tested this on my Kubernetes cluster. A small example for a pod:
Fixes: https://github.com/jaymoulin/docker-jdownloader/issues/94, https://github.com/jaymoulin/docker-jdownloader/issues/91, https://github.com/jaymoulin/docker-jdownloader/issues/82 and maybe other related.