search

jaymoulin / keeptune

Google Chrome Extension to download on Bandcamp, Soundcloud...
https://keeptune.jaymoulin.me/
Other
67 stars 6 forks source link

Add file extension #5

Closed trevd closed 7 years ago

trevd commented 7 years ago

Nice work! It would be nice if there was an option to add the file extension to the downloaded file name.

Not sure whether this only affects Linux

jaymoulin commented 7 years ago

Can you tell me more about that? Files are encoded in MP3 format, do you want to re-encode or just rename the file?

jaymoulin commented 7 years ago

Or maybe you're talking about the generated zip file?

trevd commented 7 years ago

Hi, Sorry should have been more precise :)

It's the filename's inside the generated zip file. The example url I used is https://professorelemental.bandcamp.com/album/professor-elemental-his-amazing-friends

Which produces a zipfile with the following 

Archive:  Professor Elemental - Professor Elemental & His Amazing Friends.zip
  Length      Date    Time    Name
---------  ---------- -----   ----
        0  2017-03-18 02:59   Professor Elemental/
        0  2017-03-18 02:59   Professor Elemental/Professor Elemental & His Amazing Friends/
  1926633  2017-03-18 02:59   Professor Elemental/Professor Elemental & His Amazing Friends/All You Can Eat
   816116  2017-03-18 02:59   Professor Elemental/Professor Elemental & His Amazing Friends/Intro
  3206424  2017-03-18 02:59   Professor Elemental/Professor Elemental & His Amazing Friends/More Of What You Asked For
  1053099  2017-03-18 02:59   Professor Elemental/Professor Elemental & His Amazing Friends/Cotton Club (Skit)
  3751861  2017-03-18 02:59   Professor Elemental/Professor Elemental & His Amazing Friends/Bare Witness
  2951887  2017-03-18 02:59   Professor Elemental/Professor Elemental & His Amazing Friends/BeeGees Ain't Got Nothing On Me
  3824586  2017-03-18 02:59   Professor Elemental/Professor Elemental & His Amazing Friends/All In Together (GnT Remix)
  3074767  2017-03-18 02:59   Professor Elemental/Professor Elemental & His Amazing Friends/Mectoria
  3532850  2017-03-18 02:59   Professor Elemental/Professor Elemental & His Amazing Friends/Inn At The End Of Time (Remix)
  3253236  2017-03-18 02:59   Professor Elemental/Professor Elemental & His Amazing Friends/Put Up Your Dukes
   932308  2017-03-18 02:59   Professor Elemental/Professor Elemental & His Amazing Friends/Sweet Sue (Skit)
  1585996  2017-03-18 02:59   Professor Elemental/Professor Elemental & His Amazing Friends/I Hat A Hat (Skit)
  2988668  2017-03-18 02:59   Professor Elemental/Professor Elemental & His Amazing Friends/101 Questions
  1494881  2017-03-18 02:59   Professor Elemental/Professor Elemental & His Amazing Friends/Laughing Gas (Skit)
  2542287  2017-03-18 02:59   Professor Elemental/Professor Elemental & His Amazing Friends/Wages Of Gin
  2554826  2017-03-18 02:59   Professor Elemental/Professor Elemental & His Amazing Friends/Theme Music (Extended Version)
   839939  2017-03-18 02:59   Professor Elemental/Professor Elemental & His Amazing Friends/Outro
---------                     -------

So ideally the file names should have a file extension. My use case is Downloading on Linux then transfering to Windows.

Thanks

jaymoulin commented 7 years ago

My bad, that's a silly bug. I fix that right now. Thanks for reporting me