Closed georgemarshall closed 6 years ago
At a glance this looks sane, thanks for doing this. As much as I hate py3... I guess if someone else wants to do the work, why not.
But because nearly every line changes, the GH differ can't actually show a useful diff, making this insanely difficult to review thoroughly. Please remove all the 2->4 space changes so that all the whitespace doesn't change so that the differ can actually line things up and I can do a reasonable code review.
Ah, that is much better! I didn't know about that, thanks! :)
Still - one-patch-for-one thing rule applies. If I have to back out a whitespace patch because it breaks something, it sucks to then backout the functional change. Or if I have to backout the functional patch, now I break any pending patches because it also backs out the whitespace diff.
I will split the PEP 8 changes this evening
@georgemarshall ping?
One more ping... @georgemarshall
@jaymzh I think George already splited the pep8 format to a separated commit. This PR has four commits, and you can review separately. If you don't like the format change, the first two commits just work.
Those are the original commits that came in jan 17th... he was going to split formatting and the functional changes into separate PRs. The 4th commit sits on top of the pep changes, for example. Also, none of this applies cleanly anymore.
@georgemarshall ?
I will look into this issue this week.
@georgemarshall ?
Hi, Debian declared the end-of-life for Python 2 in 2020. Is anybody working on this? Thank you!
@jaymzh
Thanks!
Hey @georgemarshall - don't think you tested this that well, it broke email support. PR coming soon
This should #2, since there are no tests it is difficult to validate everything works.