Closed apollo13 closed 2 years ago
Looking further through the code: since self.icon_size
seems to be only used as str()
in the following code, the code could be simplified even more if we would accept that self.icon-size
is a string, this would remove the need for converting to integer and back.
Splitting by all dashes and then rejoining seems to be more work than needed :)
Yep, good change 👍
Looking further through the code: since
self.icon_size
seems to be only used asstr()
in the following code, the code could be simplified even more if we would accept thatself.icon-size
is a string, this would remove the need for converting to integer and back.
Makes sense, however I think leaving it as an int
is fine. It might be a breaking change to change to str
because people might be getting the icon_size
attribute and treating it as an int
in their code.
Makes sense, however I think leaving it as an
int
is fine. It might be a breaking change to change tostr
because people might be getting theicon_size
attribute and treating it as anint
in their code.
Yeah, we could turn it into a icon_size
property which would then turn it into int (and move the original into _icon_size
, but I am not sure that is worth it.
Splitting by all dashes and then rejoining seems to be more work than needed :)