Octicons v11.0.0 - Githubissues

jaynewey / django-octicons-v10

Django templatetags for GitHub Octicons v10.0.0+.

https://pypi.org/project/django-octicons-v10/

MIT License

2 stars 4 forks source link

Octicons v11.0.0 #6

Closed jaynewey closed 4 years ago

jaynewey commented 4 years ago

Octicons recently received a major release: (v10.1.0 → v11.0.0).

https://github.com/primer/octicons/releases/tag/v11.0.0

This release introduces some breaking changes:

💅 Enhancements

Cache retrieval of Octicon SVG paths (#491)

💥 Breaking changes

Fix 24px icon names #465 (@BenJetson 🙇)
- unverifed-24.svg → unverified-24.svg
- file-symlink-24.svg → file-symlink-file-24.svg
- fire-24.svg → flame-24.svg
- eye-slash-24.svg → eye-closed-24.svg
Remove 24px settings icon. Use gear instead #493

As this repo/library is named django-octicons-v10 and updating to v11.0.0 would introduce breaking changes, there are two options at this point:

Keep this one as-is and create a new django-octicons-v11. Or:
Change this repo name to django-octicons-v11, keeping the django-octicons-v10 PyPi package, and making a new PyPi package under the new name.

jaynewey commented 4 years ago

Okay, a third option I'm considering is:

Keeping the library name as django-octicons-v10
- Pushing out the octicons v11.0.0 as a major release (2.0.0)