Fatal error in IE - Githubissues

jayphelps / core-decorators

Library of stage-0 JavaScript decorators (aka ES2016/ES7 decorators but not accurate) inspired by languages that come with built-ins like @override, @deprecate, @autobind, @mixin and more. Popular with React/Angular, but is framework agnostic.

MIT License

4.52k stars 263 forks source link

Fatal error in IE #112

Closed artptr closed 7 years ago

artptr commented 7 years ago

There is an error in IE at initialization stage in profile decorator. console.profile there isn't a "normal" function with Function prototype, so calling console.profile.bind(console) causes an error.

Fixed in #111.

jayphelps commented 7 years ago

Was fixed unknowingly in #110, released in 0.18.0

Anber commented 7 years ago

It looks like you forget to build es-version before publish 0.18.0 to npm…

jangot commented 7 years ago

Yes, I have 0.19.0v and I see the error in IE. Why is it happen?

jayphelps commented 7 years ago

@jangot can you provide more details? When I search in 0.19.0 I cannot find any cases where we call console.profile.bind. Can you share where in our code it is? What version of IE?

Triple check you really do have 0.19.0 installed in your node_modules--you might have it in your package.json but an older version is in node_modules