search

jayphelps / core-decorators

Library of stage-0 JavaScript decorators (aka ES2016/ES7 decorators but not accurate) inspired by languages that come with built-ins like @​override, @​deprecate, @​autobind, @​mixin and more. Popular with React/Angular, but is framework agnostic.
MIT License
4.52k stars 263 forks source link

Fix build on windows using cross-env package #118

Closed BurtHarris closed 7 years ago

BurtHarris commented 7 years ago

Simple enough, fixes #117

BurtHarris commented 7 years ago

Example Appveyor build at https://ci.appveyor.com/project/BurtHarris/core-decorators-js/build/1.0.4

jayphelps commented 7 years ago

yay! 🎉 thank you much!!!

jayphelps commented 7 years ago

Thank you also for the appveyor setup! Made it really simple: https://ci.appveyor.com/project/jayphelps/core-decorators-js/build/1.0.1

BurtHarris commented 7 years ago

Your are welcome @jayphelps.

But do you have any idea why the closed pull requests page now shows a red x next to this pull request?

jayphelps commented 7 years ago

@BurtHarris travis failed to build when I removed the version bump https://travis-ci.org/jayphelps/core-decorators.js/builds/234977583?utm_source=github_status&utm_medium=notification

fatal: Couldn't find remote ref refs/pull/118/merge Unexpected end of command stream

Dunno why, but presumably just a temporary connection issue to github or something.

BurtHarris commented 7 years ago

OK, I see, it failed on Travis.CI, but later succeeded.

Could you please take a look at https://stackoverflow.com/questions/44037774/requiring-npm-version-4-when-building-a-package-json/44108673 ? I'm stumped and looking for best practices, you seem like a real expert. (I've got a lot of years as a dev, but fairly new to open-source.)

jayphelps commented 7 years ago

@BurtHarris Took a look, but I don't have a solution, sorry! Does seem like a tough spot.

BurtHarris commented 7 years ago

OK, thanks anyway. I appreciate it.