search

jaypipes / ghw

Go HardWare discovery/inspection library
Apache License 2.0
1.63k stars 177 forks source link

memory: topology: expose per-numa memory #268

Closed ffromani closed 2 years ago

ffromani commented 3 years ago

This patch wants to add memory informations on topology.Node, so we can have per-NUMA-zone memory information.

WIP: tests are broken (and more needs to come), doc is missing, API is provisional. The basic concepts are there, though.

Signed-off-by: Francesco Romani fromani@redhat.com

ffromani commented 3 years ago

Thanks for your early feedback @jaypipes ! you raise very valid points and this is totally consider moving forward. At very least I'll most likely remove the hugepage portion from this PR - it wasn't requested by the issue I'm trying to fix anyway. The more I explore this area the more I see the issues you are highligthing. Once I'm confident the code does a reasonnable thing I'll lift the WIP.

ffromani commented 3 years ago

@jaypipes I think this PR is ready for another round of review. I removed all the hugepage reporting (it was at very least too premature, sorry for the noise) and fixed the pending items I had.

ffromani commented 2 years ago

@jaypipes - not urgent at all, but I think this PR is ready for review, so just keeping it on our radar

ffromani commented 2 years ago

Thanks!