Properly detect iSCSI disks

jaypipes / ghw

Go HardWare discovery/inspection library

Apache License 2.0

1.62k stars 174 forks source link

Properly detect iSCSI disks #297

Open avishayt opened 2 years ago

avishayt commented 2 years ago

iSCSI block devices are currently detected as "HDD" - it would be beneficial to detect them as "iSCSI".

jaypipes commented 2 years ago

@avishayt Sorry to get to this so late, but iSCSI is not the drive type, AFAIK. SCSI is the storage controller interface, and all iSCSI drives should appear as HDD drive type and SCSI storage controller... is there a reason we needed a separate iSCSI drive type?

@fromanirh I am considering reverting this PR...

ffromani commented 2 years ago

yes, that's actually a good point I should have considered :\