search

jaypipes / ghw

Go HardWare discovery/inspection library
Apache License 2.0
1.62k stars 174 forks source link

Detect iSCSI devices #300

Closed avishayt closed 2 years ago

avishayt commented 2 years ago

Fixes: https://github.com/jaypipes/ghw/issues/297

avishayt commented 2 years ago

thanks for the PR! indeed acknowledging ISCSI devices would be nice. It would be real cool to add unit test(s) to exercise this code, even if it's a simple change, to make it unlikely to break in the future

Added a unit test - thanks!

ffromani commented 2 years ago

thanks for the updates! codewise LGTM - we can further improve the testing in the future if needed/feasible. The only thing left is the DCO check which is failing - could you PTAL to the instructions (https://github.com/jaypipes/ghw/pull/300/checks?check_run_id=5556037529) and see if there is a easy fix? feel free to get in touch if instructions are not clear

avishayt commented 2 years ago

thanks for the updates! codewise LGTM - we can further improve the testing in the future if needed/feasible. The only thing left is the DCO check which is failing - could you PTAL to the instructions (https://github.com/jaypipes/ghw/pull/300/checks?check_run_id=5556037529) and see if there is a easy fix? feel free to get in touch if instructions are not clear

Fixed, thanks for the pointer