Closed taigrr closed 2 years ago
Looks like the project is using go <= 1.15. I'll update the code to be more backwards compatible.
the proper fix would be to NOT copy the write-only files, we had some examples of this already. But we can improve later, this seems like a good enough fix. Thanks!
Aha, I referenced the code here: https://github.com/jaypipes/ghw/blob/c82d7b1ceacb7487d9f12ef97e1ffcf65144977d/pkg/snapshot/clonetree_block_linux.go#L122-L130
Aha, I referenced the code here:
sure, again this fix is good! we can perhaps improve even more, but this can wait a bit. Better to have a working ghw-snapshot
sooner than later.
If I get some more ghw time this week, I'll perhaps post a further refinement.
@taigrr hey, sorry for the late response here, just wanted to say thank you for the bug report and the fix! :)
@jaypipes no worries, we got there :)
Please see #306 The HEAD of main already fails existing test cases, and this patch causes those test cases to pass.