search

jaypipes / ghw

Go HardWare discovery/inspection library
Apache License 2.0
1.62k stars 174 forks source link

Update core dependencies, Dockerfile, fix error in run-against-snapshot #309

Closed taigrr closed 2 years ago

taigrr commented 2 years ago

While trying to validate a snapshot created for #293 , I ran into issues using the run-against-snapshot script. It seems some of the tags for the dependencies were removed upstream, preventing the container from building.

Additionally, there was a bug in the script preventing it from running without an environment variable being set.

Finally, stretch has been unsupported for over a year at this point, and the CA store was causing issues downloading from package registries, so I updated the base image to buster, and the go tag to 1.15 from 1.13 to match the go.mod

ffromani commented 2 years ago

thanks for this change! at glance LGTM, I'll have a proper review asap

ffromani commented 2 years ago

@jaypipes was fast, I was about to approve :)