Closed jaypipes closed 2 years ago
/lgtm I was too hasty in the review. Unfortunately we need to speed up to revert to consume the important fix for https://github.com/jaypipes/pcidb/issues/28 but I'd love to resume the conversation afterwards.
/lgtm I was too hasty in the review. Unfortunately we need to speed up to revert to consume the important fix for jaypipes/pcidb#28 but I'd love to resume the conversation afterwards.
No worries, @fromanirh, it's all good :) And @avishayt, I'll start a separate conversation with you about whether there is a different (possibly new) attribute (maybe TransferProtocol or something like that?) where we can include information about things like SCSI over TCP/IP.
looks like we hit a maintenance window: https://www.githubstatus.com/incidents/qt1dj8v3whg9 I think this is safe enough to be merged anyway
Sounds good, thank you
This reverts commit 3171315ec3b21f49a6d7f61a02c6a6edb46cf843.
We can discuss whether there are merits to
ghw
determining whether a SCSI storage controller communicates via a local storage bus or via TCP/IP (iSCSI), but iSCSI is not a new drive type so I'm reverting this particular commit.Signed-off-by: Jay Pipes jaypipes@gmail.com