Open viocle-kvanek opened 2 years ago
Hi @viocle-kvanek! Thank you for the contribution! Would you mind signing your commit (git commit -s --amend
) and re-pushing? The Developer Certificate of Origin (DCO) requires commits be signed.
the change itself looks good. Let's maybe check (possibly in another PR) that this flow is covered by tests
Hi @viocle-kvanek ! to make the DCO check pass, could you please sign both of your commits https://github.com/jaypipes/ghw/pull/313/commits/8e44bc233c032fd3063de230be52d4027a6d682f and https://github.com/jaypipes/ghw/pull/313/commits/93cf72dd589f58b25344a373e86b8056c4b35765 ? The two commits can probably squashed together. If you resubmit, please considering rebase instead of merging
Windows partitions will not populate correctly because the disk index on drive and partition are being compared using the pointer address, not the value.