search

jaypipes / ghw

Go HardWare discovery/inspection library
Apache License 2.0
1.62k stars 174 forks source link

Fixes #267 dont compare pointer addresses #313

Open viocle-kvanek opened 2 years ago

viocle-kvanek commented 2 years ago

Windows partitions will not populate correctly because the disk index on drive and partition are being compared using the pointer address, not the value.

jaypipes commented 2 years ago

Hi @viocle-kvanek! Thank you for the contribution! Would you mind signing your commit (git commit -s --amend) and re-pushing? The Developer Certificate of Origin (DCO) requires commits be signed.

ffromani commented 2 years ago

the change itself looks good. Let's maybe check (possibly in another PR) that this flow is covered by tests

ffromani commented 2 years ago

Hi @viocle-kvanek ! to make the DCO check pass, could you please sign both of your commits https://github.com/jaypipes/ghw/pull/313/commits/8e44bc233c032fd3063de230be52d4027a6d682f and https://github.com/jaypipes/ghw/pull/313/commits/93cf72dd589f58b25344a373e86b8056c4b35765 ? The two commits can probably squashed together. If you resubmit, please considering rebase instead of merging