jaypipes / ghw

Go HardWare discovery/inspection library
Apache License 2.0
1.62k stars 174 forks source link

Consider updating declared Go version in go.mod #328

Closed whereswaldon closed 1 year ago

whereswaldon commented 1 year ago

The go.mod file declares go 1.15 right now. Module graph pruning was added in Go 1.17, meaning that other modules can import your module and only pick up the transitive dependencies that are actually reachable based on how they use your code. Right now, importing ghw means importing a yaml parser, a unit test framework, and a CLI flag parser because the declared go version predates go 1.17.

The tidiest dependency graph will come from using go 1.18, as:

The go.sum file recorded by go mod tidy for a module by default includes checksums needed by the Go version one below the version specified in its go directive. So a go 1.17 module includes checksums needed for the full module graph loaded by Go 1.16, but a go 1.18 module will include only the checksums needed for the pruned module graph loaded by Go 1.17. The -compat flag can be used to override the default version (for example, to prune the go.sum file more aggressively in a go 1.17 module).

Go 1.18 is also the oldest Go release still supported by the Go team, so it's a reasonable choice of language version to declare.

Thanks for all of your hard work!

jaypipes commented 1 year ago

Hi @whereswaldon! :) I'd be happy to update to go1.18. Fancy pushing up a pull request that does this and adding yourself to the list of ghw contribs? :)