search

jaypipes / ghw

Go HardWare discovery/inspection library
Apache License 2.0
1.62k stars 174 forks source link

deps: declare go 1.18 in go.mod #329

Closed whereswaldon closed 1 year ago

whereswaldon commented 1 year ago

This updates the go.{mod,sum} files to declare a version of Go that supports module graph pruning. The change allows consuming projects to avoid picking up dependencies on modules that ghw only uses for testing or for its CLI.

Fixes #328

Signed-off-by: Chris Waldon christopher.waldon.dev@gmail.com

ffromani commented 1 year ago

thanks for this PR! I'd be happy to approve considering @jaypipes seems already happy with this. Could you please check if our github actions configuration needs updates? It should be simple as doing version bumps. It would be nice to have go.{mod,sum} and CI always aligned

whereswaldon commented 1 year ago

I've attempted to update the Go versions for CI.

ffromani commented 1 year ago

Thanks a lot @whereswaldon , looks great! I'm gonna wait a little time to let @jaypipes chime in (e.g. to assess how this change interacts [if at all] with future releases plans, because we're jumping quite a bit of versions), if not I'll merge later considering the past conversation in the issue. Thanks again!