jaypipes / ghw

Go HardWare discovery/inspection library
Apache License 2.0
1.62k stars 174 forks source link

HDD is classified as SSD on windows 10 #339

Closed williambrode closed 1 year ago

williambrode commented 1 year ago

I was trying out the lib on windows 10 and was surprised to see that it was misclassifying my HDD as an SSD. Turns out the currently logic just says all "fixed" media types are SSD, which is incorrect. The "fixed" media type simply means the disk is internal to the PC, so its not "removable" media for example like a USB drive. I have what I believe to be the correct code (working for me locally) that I will create a PR for.

jaypipes commented 1 year ago

Awesome, thanks @williambrode!