Add more fields to NIC - Githubissues

jaypipes / ghw

Go HardWare discovery/inspection library

Apache License 2.0

1.62k stars 174 forks source link

Add more fields to NIC #342

Closed jak3kaj closed 1 year ago

jak3kaj commented 1 year ago

Added the following to the NIC struct:

Speed
Duplex
SupportedLinkModes
SupportedPorts
SupportedFECModes
AdvertisedLinkModes
AdvertisedFECModes

Refactoring PR #335

ffromani commented 1 year ago

I'm good with this, thank you @jak3kaj! Could probably place that readFile helper method into the util pkg long-term but I won't hold this up for that request.

@ffromani if you are good with this after review, please feel free to merge.

Looking at this ASAP

jak3kaj commented 1 year ago

I'm good with this, thank you @jak3kaj! Could probably place that readFile helper method into the util pkg long-term but I won't hold this up for that request.

@ffromani if you are good with this after review, please feel free to merge.

I'm working on the 3rd PR to add support for the WOL data. I can move readFile to utils there as well. I got busy with something else, so this will be in a week or so.