search

jaypipes / ghw

Go HardWare discovery/inspection library
Apache License 2.0
1.62k stars 174 forks source link

Read core and physical package ID of the CPUs that are online #362

Closed kishen-v closed 4 months ago

kishen-v commented 5 months ago

Fixes: https://github.com/jaypipes/ghw/issues/361

Added check to fetch the physical_package_id/core_id after determining if the CPU is online.

ffromani commented 5 months ago

LGTM

any chance to add a test or two to exercise this code?

kishen-v commented 5 months ago

Hi @ffromani, I've added a couple of tests to check if the warning is being raised in the case of missing files (core_id/physical_package_id) in the topology directory. Could you PTAL when time permits?

Thanks!