This is the first step in actually overhauling the ghw library's context package and moving to a more standard context.Context usage. In order to standardize the context usage, we needed to change the way that the ghw-snapshot functionality worked to manually construct a pkg/context.Context and call pkg/context.Context:Do() while reading the snapshot tarball.
In order to do that, I created a new ghw-snapshot read command that accepts a single argument to the snapshot tarball path to read:
A followup series of patches will make the aforementioned changes to pkg/context and remove the pkg/context.Context:Do() method and put that entirely in the cmd/ghw-snapshot/command/read.go file which is the only place we actually use it.
This is the first step in actually overhauling the ghw library's context package and moving to a more standard
context.Context
usage. In order to standardize the context usage, we needed to change the way that the ghw-snapshot functionality worked to manually construct apkg/context.Context
and callpkg/context.Context:Do()
while reading the snapshot tarball.In order to do that, I created a new
ghw-snapshot read
command that accepts a single argument to the snapshot tarball path to read:A followup series of patches will make the aforementioned changes to
pkg/context
and remove thepkg/context.Context:Do()
method and put that entirely in thecmd/ghw-snapshot/command/read.go
file which is the only place we actually use it.