search

jayqi / spongebob

SPoNgeBOb-CAse cONveRSioN ToOLs
https://jayqi.github.io/spongebob/
27 stars 3 forks source link

Fix pad length for non UTF-8 characters (fixes #13) #21

Closed wdearden closed 5 years ago

wdearden commented 5 years ago

Fixes #13 

> library(spongebob)
> foo <- paste(
+     paste0("pokémon", paste(rep(".", 25), collapse = ""))
+     , paste0("pokemon", paste(rep(".", 30), collapse = ""))
+ )
> spongebobsay(foo)
 --------------------------------------- 
| pOkÉmON.........................      |
| pOkEMon.............................. |
 --------------------------------------- 
  \\
   \\    *
          *
     ----//-------
     \..C/--..--/ \   `A
      (@ )  ( @) \  \// |w
       \          \  \---/
        HGGGGGGG    \    /`
        V `---------`--'
            <<    <<
           ###   ###
codecov[bot] commented 5 years ago

Codecov Report

Merging #21 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #21   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      3           
  Lines         144    147    +3     
=====================================
+ Hits          144    147    +3
Impacted Files Coverage Δ
R/spongebobsay.R 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 31e8342...7c6e4ed. Read the comment docs.