jayrambhia / CropperNoCropper

Instagram Style Image Cropper for Android (Library)
http://www.jayrambhia.com/project/nocropper-library
Apache License 2.0
475 stars 99 forks source link

Padding color doesn't get set from the setPaddingColor function #5

Closed faizanabidnaqvi closed 8 years ago

faizanabidnaqvi commented 8 years ago

I tried to use the setPaddingColor(color) function for the CropperView but it isn't saving it with the padding color. However, if I set the padding color from the layout file, then it works.

So I looked in your code and in your function (in CropperView), setPaddingColor doesn't set the padding color for the mImageView.

On my side I just modified your code to fix it but just letting you know too. :)

jayrambhia commented 8 years ago

@faizanabidnaqvi Thanks for this. :) I'll update the code. You should send a pull request :)

tahirSmartboy commented 8 years ago

@jayrambhia can we remove the padding ?? i want just image .....of any aspect ratio...can i do this ..plz help .....?

jayrambhia commented 8 years ago

@tahirSmartboy The cropper gives the output as a square image. So minZoom or maxZoom won't help. If you want a quick fix, you should use the source code and remove padding commands. I'll try to add it by tonight.

tahirSmartboy commented 8 years ago

@jayrambhia thanks ...ill wait till tommorow .....because i also get some error on importing any package as an offline library :(

jayrambhia commented 8 years ago

Fixed it.