search

jaysh / xposed-whatsapp

Add functional improvements to the mainstream WhatsApp Android application.
MIT License
40 stars 13 forks source link

Spanish translation #28

Closed MembriyO closed 9 years ago

MembriyO commented 9 years ago

Spanish translation - Traducción al Castellano

MembriyO commented 9 years ago

Spanish translation for the UI.

jaysh commented 9 years ago

Thanks for this.

Would it be possible for you to preserve the whitespace (indentation and blank lines) as the English version for consistency please? https://github.com/jaysh/xposed-whatsapp/blob/master/res/values/strings_activity_settings.xml

MembriyO commented 9 years ago

Not sure why the format was lost... I tried once again and from here it looks like spacing is now the same as in the English original file. I have no idea what I'm doing by the way. Feel free to tell me to stop bothering you :) Thanks again for sharing your work!

jaysh commented 9 years ago

That looks great! Thanks for the quick updates. There's a small bug (I had to test it to notice, so don't worry, it wasn't obvious at all): the structure is slightly incorrect so Android is ignoring your translations. This is because you made a tiny mistake:

https://github.com/MembriyO/xposed-whatsapp/tree/patch-1/res

This is the list of translations. The tiny mistake you made was it should be a directory called values-es and inside that, it should be called strings_activity_settings.xml. This is because you're trying to "override" this file: https://github.com/MembriyO/xposed-whatsapp/blob/patch-1/res/values/strings_activity_settings.xml - which is in the values directory. The reason it needs to be called values-es and not values-sp is just because that's how the Spanish language code is defined (http://stackoverflow.com/questions/7973023/what-is-the-list-of-supported-languages-locales-on-android).

Very close though! I can merge it after you make this small tweak.

I have no idea what I'm doing by the way

Even better! Where's the challenge otherwise?

Feel free to tell me to stop bothering you :)

Never :)

Thanks again for sharing your work!

Thanks for contributing :dancers:

Jay