jaysonsantos / terraform-provider-jumphost

Terraform provider for Hashicups demo app
7 stars 6 forks source link

Allow for using an (inline) key instead of password #4

Closed hierynomus closed 3 years ago

hierynomus commented 3 years ago

Thanks for the groundwork for this Terraform provider.

This PR adds support for using a private key to connect to the jumphost, instead of a password. Not every host running Terraform has the SSH agent running with the necessary keys. Instead you can now use a key from a file, or inline.

shimulch commented 3 years ago

@hierynomus Thanks for working on this. 👍🏽
@jaysonsantos This would be a useful feature, it would be great if you can plan some time reviewing it. :)

hierynomus commented 3 years ago

Thanks for the review, all comments have been incorporated!

scriptcoded commented 2 years ago

Hey @jaysonsantos! Just found this provider and it seems like it'd solve a lot of problems I'm facing. Can't seem to find this feature released on the Terraform Registry though. Is there a release missing perhaps?

Cheers! Malcolm

jaysonsantos commented 2 years ago

@scriptcoded it still needs work to be done because it has to somewhat fork itself and keep as a long time running process because terraform does not keep the plugin process running the whole time, its lifecycle is not documented but I assume they spawn multiple processes to make the grpc calls and kill them as soon as possible, instead of killing the process at the end. I cannot spend time on doing this, the solution I got was using a fork of postgresql's provider that knows how to tunnel (my initial use case)

scriptcoded commented 2 years ago

@jaysonsantos Oh I see, interesting. I know a bit of Go, but I've never worked with Terraform Providers before and don't think I'd be able to solve it. Otherwise I'd try. In case I for some reason try and look in to it anyways, the main branch is currently broken then?