Fix for Equals Expression and tolower OData function

jaystack / odata-v4-mongodb

This server component lets you process OData requests over a MongoDB database

30 stars 22 forks source link

Fix for Equals Expression and tolower OData function #11

Open marekkajda opened 5 years ago

marekkajda commented 5 years ago

Hi,

We are using you module and it works great, but recent changes implemented by another extensions broke it and we have implemented 2 fixes:

Parsing correctly filter like: not (documentStatus eq 'OPEN'), current version parsing it to: documentStatus: not 'OPEN'
handling tolower OData function

aaghevli commented 5 years ago

Thanks for the PR @marekkajda! Sorry for the delay. It seems like this would best be served with two PRs since the toLower seems much safer a change than the equality change though they both look good.

What do you mean "recent changes implemented by another extensions broke it"?

Sorry for being pedantic but I was only recently added to this project and am not sure of the scope.

Overall these changes look good however so I hope to move this along this week.

aaghevli commented 5 years ago

I added some hopefully simple requests for updates if you wish to merge these. Thanks again!