search

jaystrictor / gnome-shell-extension-syncthing

GNU General Public License v3.0
87 stars 14 forks source link

Strange looking status notification #12

Closed cyn1c closed 8 years ago

cyn1c commented 8 years ago

First of all, the addition of the status information is an great thing, thanks for that. I use the extensions on two systems right now, on one it looks exactly the same as it looks in the screenshot on the gnome extensions page. On my laptop (running Antergos Linux) there is no such beautiful looking sync symbol next to the syncthing icon, just a bar as you can see in the screenshot i add to this issue report. Is this a known problem which could be fixed? screenshot

jaystrictor commented 8 years ago

Thanks for the feedback.

Currently, the sync symbols are not stored as images. Instead they are just some unicode characters. I assume your Antergos system doesn't know how to render these characters, maybe because it lacks a certain font. In the long run, I want to replace the unicode characters by a proper SVG logo. However, I am not a logo designer, so any help is appreciated.

Could you check on both of your systems, whether you can see the characters in the source code? Maybe you could even post a screenshot of that link?

cyn1c commented 8 years ago

You are right. One the Antergos system the symbol is not shown correctly, while the other system has no problem showing the character. bildschirmfoto von 2016-03-26 12-31-35 The symbola font was missing on the Antergos system. After installing the font everything looks good!

jaystrictor commented 8 years ago

Ok, good that it works for you. Still... I would like for it to work out of the box on every system. But I guess this can only be achieved if the unicode characters are replaced by proper SVG logos.

cyn1c commented 8 years ago

I guess you are right. To bad i'm terrible at everything involving creating graphics. Maybe you could use the current svg and make different colored versions for every status?

jaystrictor commented 8 years ago

There are already some discussion going on in a pull request. I hope this extension can profit from that some day.

jaystrictor commented 8 years ago

We should extract some SVG glyphs from a free font and include them in /icons, as @KopfKrieg suggests in PR #15 .

KopfKrieg commented 8 years ago

Wow, that was fast! The icons are fine, the extensions is working great so far. Just two little things:

First, the "pause" icon is a little bit too big (in width, not in height) in my opinion (and maybe there should be a space between the syncthing and the pause icon). Here's what I mean: extension

And second, the icons could be a little bit darker. But maybe that's just on my system, because I've enabled the global dark theme.

Everything else: Perfect!

jaystrictor commented 8 years ago

You can change the size of the symbols and the space between both of them in the file stylesheet.css. Currently it is set as icon-size: 0.75em and padding-left: 2px. What values do you propose?

KopfKrieg commented 8 years ago

Hm, good question. The icon-size is fine (In my previous post I meant the pause icon per se, not its size). For the padding-left, maybe about 6px? Looks a bit more separated.