search

jaystrictor / gnome-shell-extension-syncthing

GNU General Public License v3.0
87 stars 14 forks source link

add a "Syncthing INotify" switch #22

Closed Palatis closed 8 years ago

Palatis commented 8 years ago

toggles the syncthing-inotify.service

jaystrictor commented 8 years ago

Hmm, I already had a discussion about that topic with @rumpelsepp on the Syncthing forum. Since this patch, syncthing-inotify is started and stopped with syncthing. So I don't see the need to add another switch.

Please feel free to convince me otherwise, ...

Palatis commented 8 years ago

syncthing.service and syncthing-inotify.service are different service. sometimes user forget to install the inotify service, but syncthing still gonna work (it just have to do the periodical scanning before it knows some file changed).

I think having a switch there to indicate service status is a good idea, anyway.

jaystrictor commented 8 years ago

Sorry, I don't want to merge this. I have the impression that the issue you describe would better be addressed by giving the user a unobtrusive notification that syncthing-inotify is not running/not available. I don't see the need for a second on/off switch.

Palatis commented 8 years ago

so, would you accept an inotify service indicator? like it just tell the user if the inotify service is installed/running or not, but unable to control the on/off state of the service?

the user will have to issue systemctl --user start/stop syncthing-inotify somewhere else to control the service status.

Palatis commented 8 years ago

and maybe just hide the message if the inotify service is up and running.

in a "no smoke, no problem." manner.

jaystrictor commented 8 years ago

Yes, seems like a good idea. Thank you for working on that.

jaystrictor commented 8 years ago

Also note that the user will not have to issue systemctl --user start/stop syncthing-inotify manually, simply because if syncthing-inotify.service is available, it is started and stopped with syncthing.service.

Palatis commented 8 years ago

I mean, we can't imagine how user would like to use the program. Maybe he/she wants to start syncthing without the inotify service? Although I can't think of a case that anyone would do that, but... Who knows!

jaystrictor commented 8 years ago

True, we can't know for sure in what ways users would like to use the extension. We can however assume that they want to use it in a resource-efficient way, so usually they would want to have inotify. As long as we assume that, we should not add the option to disable inotify.

Furthermore, the syncthing team plans to merge inotify into syncthing. When this is done, the second switch would be obsolete.