Compatibility with 3.30

[KopfKrieg]

Currently the extension is not officially compatible with Gnome Shell v3.30. Could you make it compatible? It's probably just a version adjustment necessary.

[jaystrictor]

I cannot test this on 3.30. Could someone just confirm that the extension works on 3.30, then I am happy to bump the version.

[KopfKrieg]

I'm sorry, but after playing around with it, I think a version adjustment alone won't be enough. Unfortunately I also don't know how to debug that :/

Edit: I've got an error log:

Sep 20 23:41:56 Geralt gnome-shell[22485]: JS WARNING: [resource:///org/gnome/shell/ui/extensionDownloader.js 86]: reference to undefined property "GLocalFileOutputStream"
Sep 20 23:41:56 Geralt org.gnome.Shell.desktop[22485]: Archive:  /tmp/MFUVPZ.shell-extension.zip
Sep 20 23:41:56 Geralt org.gnome.Shell.desktop[22485]:   inflating: /home/me/.local/share/gnome-shell/extensions/syncthingicon@jay.strict@posteo.de/sax.js
Sep 20 23:41:56 Geralt org.gnome.Shell.desktop[22485]:   inflating: /home/me/.local/share/gnome-shell/extensions/syncthingicon@jay.strict@posteo.de/icons/exchange.svg
Sep 20 23:41:56 Geralt org.gnome.Shell.desktop[22485]:   inflating: /home/me/.local/share/gnome-shell/extensions/syncthingicon@jay.strict@posteo.de/icons/question.svg
Sep 20 23:41:56 Geralt org.gnome.Shell.desktop[22485]:   inflating: /home/me/.local/share/gnome-shell/extensions/syncthingicon@jay.strict@posteo.de/filewatcher.js
Sep 20 23:41:56 Geralt org.gnome.Shell.desktop[22485]:   inflating: /home/me/.local/share/gnome-shell/extensions/syncthingicon@jay.strict@posteo.de/schemas/org.gnome.shell.extensions.syncthing.gschema.xml
Sep 20 23:41:56 Geralt org.gnome.Shell.desktop[22485]:   inflating: /home/me/.local/share/gnome-shell/extensions/syncthingicon@jay.strict@posteo.de/icons/syncthing-logo-symbolic.svg
Sep 20 23:41:56 Geralt org.gnome.Shell.desktop[22485]:   inflating: /home/me/.local/share/gnome-shell/extensions/syncthingicon@jay.strict@posteo.de/stylesheet.css
Sep 20 23:41:56 Geralt org.gnome.Shell.desktop[22485]:   inflating: /home/me/.local/share/gnome-shell/extensions/syncthingicon@jay.strict@posteo.de/icons/syncthing-logo.svg
Sep 20 23:41:56 Geralt org.gnome.Shell.desktop[22485]:   inflating: /home/me/.local/share/gnome-shell/extensions/syncthingicon@jay.strict@posteo.de/webviewer.js
Sep 20 23:41:56 Geralt org.gnome.Shell.desktop[22485]:   inflating: /home/me/.local/share/gnome-shell/extensions/syncthingicon@jay.strict@posteo.de/icons/database.svg
Sep 20 23:41:56 Geralt org.gnome.Shell.desktop[22485]:   inflating: /home/me/.local/share/gnome-shell/extensions/syncthingicon@jay.strict@posteo.de/prefs.js
Sep 20 23:41:56 Geralt org.gnome.Shell.desktop[22485]:   inflating: /home/me/.local/share/gnome-shell/extensions/syncthingicon@jay.strict@posteo.de/extension.js
Sep 20 23:41:56 Geralt org.gnome.Shell.desktop[22485]:   inflating: /home/me/.local/share/gnome-shell/extensions/syncthingicon@jay.strict@posteo.de/icons/pause.svg
Sep 20 23:41:56 Geralt org.gnome.Shell.desktop[22485]:   inflating: /home/me/.local/share/gnome-shell/extensions/syncthingicon@jay.strict@posteo.de/icons/exclamation-triangle.svg
Sep 20 23:41:56 Geralt org.gnome.Shell.desktop[22485]:   inflating: /home/me/.local/share/gnome-shell/extensions/syncthingicon@jay.strict@posteo.de/README.md
Sep 20 23:41:56 Geralt org.gnome.Shell.desktop[22485]:   inflating: /home/me/.local/share/gnome-shell/extensions/syncthingicon@jay.strict@posteo.de/convenience.js
Sep 20 23:41:56 Geralt org.gnome.Shell.desktop[22485]:   inflating: /home/me/.local/share/gnome-shell/extensions/syncthingicon@jay.strict@posteo.de/schemas/gschemas.compiled
Sep 20 23:41:56 Geralt org.gnome.Shell.desktop[22485]:  extracting: /home/me/.local/share/gnome-shell/extensions/syncthingicon@jay.strict@posteo.de/metadata.json
Sep 20 23:41:56 Geralt gnome-shell[22485]: Some code accessed the property 'ENABLED_EXTENSIONS_KEY' on the module 'extensionSystem'. That property was defined with 'let' or 'const' inside the module. This was previously supported, but is not correct according to the ES6 standard. Any symbols to be exported from a module must be defined with 'var'. The property access will work as previously for the time being, but please fix your code anyway.
Sep 20 23:41:56 Geralt gnome-shell[22485]: Extension "syncthingicon@jay.strict@posteo.de" had error: SyntaxError: missing ) after catch

[dirusulixes]

I can confirm the error when trying to enable the extension in 3.30.

[jaystrictor]

Ahh I missed your edit @KopfKrieg. Sorry. Trying to fix that now.

[jaystrictor]

@njam did some work on this.

Could you test the current commit and report back how it works for you, @KopfKrieg ?

[sanjayankur31]

@jaystrictor : I installed commit fe6f651 manually, and seems to work just fine. The icon is back in the top bar, and the buttons etc. are all functional too. Thanks :)

$ rpm -q gnome-shell
gnome-shell-3.30.1-1.fc29.x86_64

[KopfKrieg]

@jaystrictor I can confirm the latest commit (fe6f651) is working with gnome-shell 3.30.1.

Thank you very much!

[jaystrictor]

Thank you both for testing. Uploaded the new version to extensions.gnome.org. Should be online after review.

[da-n]

I might be missing something obvious, sorry if this is the case, but the most recent version on extensions.gnome.org seems to be against 3.26? Am I being dumb? Thanks.

[jaystrictor]

As I said, I uploaded the new version. That doesn't mean that you can already download it.

Now the Gnome team has to review this version. Only after successful review, the version is released to the public. This usually takes some days. I think recently they have been really busy and it could even take some weeks.

If you are impatient, just install the version from upstream. (./install.sh)

[da-n]

Ah of course, that makes total sense thank you for explaining. I have installed from git and all working. Many thanks.