search

jaystrictor / gnome-shell-extension-syncthing

GNU General Public License v3.0
87 stars 14 forks source link

Remove "conditional catch" syntax #37

Closed njam closed 6 years ago

njam commented 6 years ago

Because it's not supported in Gnome 3.30's JS engine anymore

For #36

njam commented 6 years ago

@jaystrictor probably we've been doing the same thing at the same time :D

jaystrictor commented 6 years ago

True. :D I think your fix looks good. But on the other hand, I just thought about whether we need the condition instanceof Gio.IOErrorEnum at all. I believe we should return a generic icon unconditionally. What do you think?

njam commented 6 years ago

On the other hand if any other exception is thrown - and thus a yet unknown error happens - probably it should not be ignored, because it could hide possibly important information.

I don't know much about this code though, it's of course your decision!

jaystrictor commented 6 years ago

Ok, let's do it this way.