search

jaystrictor / gnome-shell-extension-syncthing

GNU General Public License v3.0
87 stars 14 forks source link

Bugfix/invisible icon #62

Closed free-bots closed 3 years ago

free-bots commented 3 years ago

This fixes #61

the icon was visible but very tiny (white dot in preview): svg_original

After moving the circle in inkscape and center it again: svg_modified

Icon is now visible but not centered due to unnecessary css: replace_svg

After removing css : fixed_styling

jaystrictor commented 3 years ago

Thank you for taking your time to solve this issue. With your altered SVG, the icon itself seems to be displayed correctly. I cannot tell the difference between the old and the new SVG. When opened in Inkscape they seem to be pretty similar. So what exactly is the difference between the two?

However, the reason why the CSS is how it is, is the following: When displaying two icons in parallel (like the Syncthing icon and a pause icon) there should be only very little space between the two. I am afraid that without the padding=0, the icons are too far apart.

free-bots commented 3 years ago

There was a typo that caused this issueheigth -> height.

For me with or without the css the gap looks the same. without css: 1 2 with css: 3 4

jaystrictor commented 3 years ago

Ahh, nice catch, thank you.

For me, without the CSS the gaps look actually different. But I guess it's better to have consistent experience, so delete the CSS for now.