search

jaytaylor / ansible-kafka

Ansible Kafka role
https://galaxy.ansible.com/jaytaylor/kafka/
Other
67 stars 52 forks source link

Fix hard coded user/group in sysmted unit #16

Closed kcdbaba closed 7 years ago

kcdbaba commented 7 years ago

Can we please have a tag if this gets merged in?

jaytaylor commented 7 years ago

@fissurezone I'm happy to merge this, but the default group will need to be "kafka" rather than "root".

Once that's fixed I'm happy to merge and create a tag for you.

Best, Jay

kcdbaba commented 7 years ago

@jaytaylor i dont think the package creates a group called kafka. will have to add that in. are you sure you want this?

jaytaylor commented 7 years ago

@fissurezone It's previously been working- looks like the user and group are created together here:

user: name={{ kafka_user }} system=yes group={{ kafka_group }}

So yeah, let's keep it the same unless there is a compelling reason to change it.

Best, Jay

jaytaylor commented 7 years ago

Thanks @fissurezone !

kcdbaba commented 7 years ago

hey @jaytaylor, looks like you have a typo in the tag v1,2.0

jaytaylor commented 7 years ago

Thanks, fixed!

On Feb 28, 2017, at 8:40 PM, Kunal Chowdhury notifications@github.com wrote:

hey @jaytaylor, looks like you have a typo in the tag v1,2.0

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.