flag to disable the builtin java/JDK deployment

jaytaylor / ansible-kafka

Ansible Kafka role

https://galaxy.ansible.com/jaytaylor/kafka/

Other

67 stars 52 forks source link

flag to disable the builtin java/JDK deployment #19

Closed lhoss closed 7 years ago

lhoss commented 7 years ago

Best is to be able to completely disable the builtin deployment of java(jdk) which is hardcoded and pointing to old JDK7. This also allows to run the role in check-mode for most parts. Patch is 100% downward compatible ( as the new flag is enabled by default )

Other PR coming, that adds 2 more check_mode: no, so the role can be completely --check tested 👍

happy to get this merged @jaytaylor , thx in advance !

lhoss commented 7 years ago

travis looks good, except failure in:

Idempotence test: fail

jaytaylor commented 7 years ago

Thanks for the clear explanation, this looks good!