search

jaytaylor / ansible-kafka

Ansible Kafka role
https://galaxy.ansible.com/jaytaylor/kafka/
Other
67 stars 52 forks source link

use ansible_service_mgr instead of custom logic … #34

Closed lhoss closed 6 years ago

lhoss commented 6 years ago

…(also fixes check mode in the install part)

Would be great @jaytaylor ! Assuming this gets merged, I will also resolve conflict with https://github.com/jaytaylor/ansible-kafka/pull/21

jaytaylor commented 6 years ago

Greetings @lhoss,

Are you able to rebase against current master? The CI tests are now passing there, and assuming they pass with this commit I'll merge it.

lhoss commented 6 years ago

I rebased, and indeed the ansible 2.0.x tests (still) green 👍 but the 1.9.x builds are failing due to the new ansible_service_mgr checks:

TASK: [ansible-kafka | Create upstart config] ********************************* 
fatal: [localhost] => error while evaluating conditional: ansible_service_mgr != 'systemd'

I will create a PR to give up any pre v2 support, instead test builds with recent 2.2.x and 2.4.2 I'ld suggest 👍

jaytaylor commented 6 years ago

@lhoss Fabulous :D

lhoss commented 6 years ago

yeah ... and rebased this PR on master, so the builds now passed :) happy to get it merged ... @jaytaylor 👍

jaytaylor commented 6 years ago

Thank you @lhoss.