jaytaylor / ansible-kafka

Ansible Kafka role
https://galaxy.ansible.com/jaytaylor/kafka/
Other
67 stars 52 forks source link

Log and config convenience options #9

Closed eladamitpxi closed 7 years ago

eladamitpxi commented 7 years ago

switched host defs to be based on a collection added option to disable the health check by using a 0 value for the timeout fixing incorrect host list creation name added misc server settings option changing systemd to use the env file for it to be more robust fixed log dir assignment to work from the ansible var extracted log levels to role vars

eladamitpxi commented 7 years ago

is this repo still under maintenance?

jaytaylor commented 7 years ago

Yes, my apologies for not following up sooner. I'll check this out later today or tomorrow.

On Oct 10, 2016, at 12:11 PM, eladamitpxi notifications@github.com wrote:

is this repo still under maintenance?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

eladamitpxi commented 7 years ago

cool, tx :)

On Tue, Oct 11, 2016 at 6:30 PM, Jay Taylor notifications@github.com wrote:

Yes, my apologies for not following up sooner. I'll check this out later today or tomorrow.

On Oct 10, 2016, at 12:11 PM, eladamitpxi notifications@github.com wrote:

is this repo still under maintenance?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jaytaylor/ansible-kafka/pull/9#issuecomment-252952454, or mute the thread https://github.com/notifications/unsubscribe-auth/AP_4Frz3p8itAqLgEE03H3WhHZ5Ap8Snks5qy6uQgaJpZM4KOwn8 .

jaytaylor commented 7 years ago

@eladamitpxi Thanks for your attention to detail and cleanup!

For some (probably unrelated reason) Kafka 2.x travis tests are still failing.

LGTM for Kafka 1.x series.

eladamitpxi commented 7 years ago

my pleasure :)