search

jayunit100 / bigpetstore

[OBSOLETE] Moved to Apache BigTop !!! See you there.
http://jayunit100.github.io/bigpetstore/slides
9 stars 3 forks source link

Overuse of the Constants class #11

Closed jayunit100 closed 10 years ago

jayunit100 commented 10 years ago

I think we are overusing the constants class

We shouldnt globally manage tmp directories that are only used by a unit test. if a unit test needs a tmp directory, let it store that variable itself.

I've deprecated these files accordingly, lets delete them ASAP and move all test related constants into the tests themselves.

nsavageJVM commented 10 years ago

no more tmp/xxx directorys I have removed all the code with @Depreciated tags the tests pass on my box I will not close this issue yet I still have 1 relative path in the hive test './d3/cities.csv' we have to load the data somehow there are no absolute paths anywhere you were correct no need to create a hive test database