search

jayvan / tempest-watch

Track active tempests in Path of Exile
zlib License
7 stars 5 forks source link

Report from Maps page #22

Closed MMcCormick closed 9 years ago

MMcCormick commented 9 years ago

Notes:

-should dump.rdb be ignored with .gitignore? -doesn't auto-refresh after submission

jayvan commented 9 years ago

I really like the in-line voting, but we're going to have to look at optimizing this first. The size of the main page went from 50kb to 500kb The time to DOM ready went from 300ms to 2650ms Because the DOM is so heavy, it also takes 4367ms for the in-line form to appear.

I think there are big saving to having 1 report form, and moving it, rather than having 1 form per map.

MMcCormick commented 9 years ago

Yeah, you're right. But it shouldn't be hard to just copy one form and then fill in the map field value. On Sun, Jul 26, 2015 at 10:27 AM Justin Vanderheide < notifications@github.com> wrote:

I really like the in-line voting, but we're going to have to look at optimizing this first. The size of the main page went from 50kb to 500kb The time to DOM ready went from 300ms to 2650ms Because the DOM is so heavy, it also takes 4367ms for the in-line form to appear.

I think there are big saving to having 1 report form, and moving it, rather than having 1 form per map.

— Reply to this email directly or view it on GitHub https://github.com/jayvan/tempest-watch/pull/22#issuecomment-124997266.

MMcCormick commented 9 years ago

Much faster for me, now. Let me know if you have any other improvements.

MMcCormick commented 9 years ago

Oh, one other thing - I commented out the conditional hiding / showing of the thumb buttons, so that the form could be accessed via the downvote. Obviously this isn't right for user experience, but I wanted your input on how you want it to work. @jayvan

jayvan commented 9 years ago

Maybe show a + icon instead? The materialize website has a list of icons available. I can take a look and probably merge this tonight when I get home. On Jul 26, 2015 15:17, "Matt McCormick" notifications@github.com wrote:

Oh, one other thing - I commented out the conditional hiding / showing of the thumb buttons, so that the form could be accessed via the downvote. Obviously this isn't right for user experience, but I wanted your input on how you want it to work.

— Reply to this email directly or view it on GitHub https://github.com/jayvan/tempest-watch/pull/22#issuecomment-125030073.

MMcCormick commented 9 years ago

Oddly enough, Materialize didn't have one, but I styled a + that looks natural, I think.