search

jayvan / tempest-watch

Track active tempests in Path of Exile
zlib License
7 stars 5 forks source link

Testing #3

Closed MMcCormick closed 9 years ago

MMcCormick commented 9 years ago

@jayvan how do you feel about testing? I think rspec would help me make sure we keep older versions of the API working as we find out more. Ideally, you wouldn't need to implement anything outside of what I do (unless you'd like to)

jayvan commented 9 years ago

Testing is great, I've held off for now since we don't really know 100% how tempests work yet. If you'd like to get something in place that would be awesome! Looking to freeze the API the day after the expansion is released. On Jul 6, 2015 10:32 PM, "Matt McCormick" notifications@github.com wrote:

@jayvan https://github.com/jayvan how do you feel about testing? I think rspec would help me make sure we keep older versions of the API working as we find out more. Ideally, you wouldn't need to implement anything outside of what I do (unless you'd like to)

— Reply to this email directly or view it on GitHub https://github.com/jayvan/tempest-watch/issues/3.

jayvan commented 9 years ago

Testing has been added for the /api/v0/tempests route :+1: Feel free to increase coverage, I'll work on specs this weekend once we have v1 and we're happy with it :)