search

jaywcjlove / idoc

:book: Simple document generation tool! Dependence Node.js run.
https://git.io/idoc
MIT License
283 stars 65 forks source link

Fixed media query for mobile #70

Closed Cryptizism closed 1 year ago

Cryptizism commented 1 year ago

This code change makes it so that there is no grid when viewed on a mobile (anything with max width 900px) as the navbar is already removed and there is no need for this extra whitespace.

Before: image After: image

Notice how there is a gap in the first one on the right, this is due to the grid, setting this to a display of block will get rid of this and in the same media query the navbar is disregarded (display:none) so there is no need for that empty space or to display it elsewhere

jaywcjlove commented 1 year ago

@Cryptizism I feel like it has been fixed. Upgrade idoc@v1.25.0+

image

I have upgraded the dependencies and the problem is resolved

image

Cryptizism commented 1 year ago

@Cryptizism I feel like it has been fixed. Upgrade idoc@v1.25.0+

image

I have upgraded the dependencies and the problem is resolved

image

Ah, I see I didn't realise there was a new update, I should've double checked before I made this PR. I will check if this resolves my issue aswell in the morning and if so I will close this PR

jaywcjlove commented 1 year ago

After my test, this problem has been solved.