Organize code according to PSR-0

jaz303 / phake

A rake/make clone for PHP 5.3

365 stars 27 forks source link

Organize code according to PSR-0 #20

Closed clue closed 11 years ago

clue commented 11 years ago

This PR re-organizes the code to adhere to PSR-0. This is a required to include this project as a dependency into other projects (more PRs to follow to give some more insight). It also vastly simplifies working with the source code, because each class is in an independent file.

It does NOT change any of the existing code.

jaz303 commented 11 years ago

looks cool, can you please fix this bug then I'll merge:

jason@disco phake % ./bin/phake ● [remotes/clue/psr0] #18

Fatal error: Cannot redeclare phake\resolve_runfile() (previously declared in /Users/jason/dev/projects/phake/lib/phake/utils.php:5) in /Users/jason/dev/projects/phake/lib/phake/Utils.php on line 19

clue commented 11 years ago

Thanks for the ridiculously fast response :+1: :)

Strange error, I have just re-checked that running bin/phake works fine here. Utils.php:19 shouldn't redeclare this function either, so I guess we have a naming issue due to lowercase utils.php and uppercase Utils.php.

Are you okay with me moving some of the logic around to avoid that situation?

jaz303 commented 11 years ago

yep go for it.

clue commented 11 years ago

Alright, decided against moving the logic and went with renaming the files.

Working fine here. Can you confirm?

jaz303 commented 11 years ago

yep works fine here, merged.

clue commented 11 years ago

Great! Thanks for the quick response :+1: