search

jazerler / pe

0 stars 0 forks source link

Activity Diagram for AddExpenseCommand has unnecessarily long condition #22

Open jazerler opened 4 years ago

jazerler commented 4 years ago

Definition of valid command should be defined somewhere like the glossary and not within the diagram itself, especially if the same definition can be used elsewhere. image.png

nus-se-bot commented 4 years ago

Team's Response

This is something specific to addExpense command since some values are optional, so I felt it would be good stating it clearly. It is not really a definition that should be stated, but it is just important to point out here that, in the case of addExpense command, the compulsory(non- optional) values should all be present.

Anyways, thanks for pointing out!

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]