search

jazkarta / edx-platform-for-isc

fork of the edx platform for development w/ isc
GNU Affero General Public License v3.0
1 stars 2 forks source link

ISC Customizations: Preserve changes to enrollment and login #14

Open cewing opened 9 years ago

cewing commented 9 years ago

The changes in these three changesets:

should be preserved. The expected outcome is that for a course with an enrollment domain set, the email address of a student must match that domain in order for successful enrollment. The domain should be compared in a case-insensitive way. The current approach is to normalize the email domain to lowercase on storage.

The final changeset causes a student to have to log in explicitly after activating their account. This is different from the standard EdX implementation which logs a student in automatically upon account activation. There is an open question regarding the need to preserve this specific change.

cewing commented 9 years ago

@natea: the document leaves it unclear whether the point about disallowing immediate login for students on activation is desired. Can we get follow-up on that question?

bryanlandia commented 9 years ago

@natea - I'll start on issue 14 other than the last changeset and wait to see your reply to cewing's question about disallowing immediate login.

bryanlandia commented 9 years ago

I'll normalize to a lowercase comparison with User email domain in the can_enroll method, too, so that we catch User objects created before the implementation of the normalization via receiver in the Student model file.

bryanlandia commented 9 years ago

Changesets 1 and 2 complete.

natea commented 9 years ago

Jeanne from ISC says: "It is best to do this to prevent misuse. Making real users confirm that the email is valid and that they made the request prevents automatic generation from bots and mischief makers, etc. If you don't have this, you may find your environment hijacked with many environments spun up - taxing resources and adding to overall cost. Better to make them take the extra step I think."

natea commented 9 years ago

@bryanlandia what about the 3rd changeset?

bryanlandia commented 9 years ago

@natea - Starting on this in a minute...

bryanlandia commented 9 years ago

Merged fix branch to isc-birch-patches branch. @natea - ready to review.

bryanlandia commented 9 years ago

changeset 3 (no auto login after user account creation) confirmed working on isc_appsembler dev site