Closed cguardia closed 9 years ago
@cguardia here is coverage report, need to look into coverage of field_overrides.py (75 %)
@cewing: my gut is no, that filtering the providers and not doing the lineage is going to be significantly better. That said, we'd want to be sure that we aren't filtering the list of providers more than one per request (for instance), and that we aren't requiring each provider to instantiate the course on their own.
For instance, we could put the set of provider classes in cls.provider_classes
, but produce a filtered version of that list each time we instantiate the block. And we can cache (using RequestCache
, for instance, or a thread-local object) the mapping of course -> enabled providers, so that we don't have to call the provider API for every course for every block.
@pdpinch list is update
there are coverage issues
Made this into a WIP PR on edx:
…ge when ccx is not enabled