search

jazkarta / edx-platform

the edX learning management system (LMS) and course authoring tool, Studio
http://code.edx.org/
GNU Affero General Public License v3.0
1 stars 0 forks source link

Move CCX-related field overrides to happen at the modulestore layer... #79

Closed pdpinch closed 9 years ago

pdpinch commented 9 years ago

... so that content-related services like search and course structures can query with the new CCX course keys.

Depends on #43

pdpinch commented 9 years ago

@bdero this was a request from Dave Ormsbee. Do you think this would have any affect on

a) our memory issues b) where we might control overrides at a per-course level?

bdero commented 9 years ago

I'm actually not too sure what this means. Is this CCX-specific, or is this a proposal for reimplementing field overrides to not be a field data wrapper? What does it mean for e.g. the content search feature to "query with the new CCX course keys"? Is this because the field data will only be filtered while rendering, but features like the search service query the course tree in a more direct way?

bdero commented 9 years ago

If I'm guessing right, the intention is to make field override providers work whenever something tries to read field data - in which case I don't think it will have an effect on the performance/memory problem.

pdpinch commented 9 years ago

I think you're right @bdero. In fact, this might expand the set of cases where we run into memory issues, depending on how these other services walk the course tree.

pdpinch commented 9 years ago

According to Dave Ormsbee at edX, this was already addressed in https://github.com/edx/edx-platform/pull/8519