jazkarta / jazkarta.shop

A web-based shop for Plone
GNU General Public License v2.0
4 stars 2 forks source link

Allow Selecting States for TaxJar Lookup #27

Open alecpm opened 8 years ago

alecpm commented 8 years ago

Since the South Dakota state specific tax calculator currently just uses TaxJar conditional on the state entered, we should probably consider adding support to the default TaxJar tax provider to allow configuring which states to lookup tax rates for. That seem like a better solution than having separate state tax providers that just use TaxJar as the backend.

skleinfeldt commented 8 years ago

IIRC @alecpm we only need to look up tax for South Dakota. Taxjar was the solution because there is no SD state agency provided API. I think.

alecpm commented 8 years ago

I get that, but it's quite a common need for an online retailer to only need to calculate taxes for buyers in states that they have some sort of physical presence. I'm suggesting that jazkarta.shop rather than have a single special case plugin for doing SD taxes only using TaxJar, it should have a picklist that allows you an admin to select the states they want to calculate tax for. That would be a generic solution to this problem for any and all states that don't provide a native API for tax lookup.

skleinfeldt commented 8 years ago

Sorry in my haste didn't notice what tracker I was in @alecpm

witekdev commented 7 years ago

maybe @davisagli can weigh in his thoughts here too at some point (not that this is a priority given other bugs and enhancements on the back burner).

davisagli commented 7 years ago

This makes sense to me if and when we have a client in a different state that wants to use TaxJar

witekdev commented 7 years ago

That functionality is already in place, in the sense that if you are in a different state you can use the complete TaxJar SmartCalcs State Tax Handler, not the one that ignores all states but SD. (At the moment we have 3 options the WA state tax handler (from Mtneers), the TaxJar SmartCalcs State Tax Handler and the South Dakota State Tax handler (using TaxJar and only calculating if the user ships to SD).

The question here is whether there should be another handler or functionality that allows a user to pick which states they want to charge tax to, and which not.

but maybe this was already clear to you @davisagli unless I misunderstood your response?

davisagli commented 7 years ago

Hmm, I'm not really clear on what is best, so I would wait until a customer needs something different than what we have to make changes.

witekdev commented 7 years ago

That seems like the best approach in my opinion too, as we have plenty of other more pressing issues to fix when we get a moment.